Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support the TiFlash replica of table #12453
*: support the TiFlash replica of table #12453
Changes from 8 commits
4ec146d
5ceeb6f
e1e46cc
3eaa30c
5debf92
de738e8
5f0ab30
e17d7bc
a99d991
8826872
3a8376a
ca5f264
0d5381b
05d02a6
401df18
a82fcff
6f93629
02aa042
529ebd2
9aa9835
ff877c8
fd30dc5
ea5275b
d6b36d0
50f93cb
76a9be5
9f0c9d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
alter table t_flash set tiflash replica 2 location labels 'a','a';
?If labels are the same, is it OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK. PD will get the same labels and deduplicate.