Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: record query start time to session variables (#11822) #12676

Merged
merged 5 commits into from
Oct 14, 2019
Merged

*: record query start time to session variables (#11822) #12676

merged 5 commits into from
Oct 14, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #11822 to release-2.1

original PR description:

Signed-off-by: Zhang Jian zjsariel@gmail.com

What problem does this PR solve?

move the following 3 metrics from StatementContext to SessionVars:

  • StartTime time.Time
  • DurationParse time.Duration
  • DurationCompile time.Duration

StatementContext will be reset when the physical plan is executed. All the metrics are reset.

What is changed and how it works?

As described above.

Check List

Tests

  • Unit Test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Oct 14, 2019
@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason zz-jason requested review from jackysp and lysu October 14, 2019 03:16
jackysp
jackysp reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lysu
lysu approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 14, 2019
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

Your auto merge job has been accepted, waiting for 12680

@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

/run-all-tests

@sre-bot sre-bot merged commit 58341c3 into pingcap:release-2.1 Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zz-jason @sre-bot @lysu @jackysp @ngaut