Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/admin: fix the error of "invalid list index" when cancel ddl jobs (#12402) #12681

Merged
merged 5 commits into from
Oct 21, 2019
Merged

util/admin: fix the error of "invalid list index" when cancel ddl jobs (#12402) #12681

merged 5 commits into from
Oct 21, 2019

Conversation

zimulala
Copy link
Contributor

cherry-pick #12402 to release-2.1

@zimulala zimulala added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Oct 14, 2019
zz-jason
zz-jason reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2019
@zimulala
Copy link
Contributor Author

PTAL @crazycs520 @winkyao

crazycs520
crazycs520 approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@zimulala
Copy link
Contributor Author

/run-integration-common-test

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2019
@zimulala
Copy link
Contributor Author

/run-unit-test

@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit 355e19c into pingcap:release-2.1 Oct 21, 2019
@zimulala zimulala deleted the cancel-job branch March 1, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zimulala @crazycs520 @sre-bot @zz-jason @ngaut