Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: invalid year should be 0 (#12715) #12744

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Oct 16, 2019

cherry-pick #12715 to release-2.1


What problem does this PR solve?

Invalid year should be "0000". Fix #12615

What is changed and how it works?

Return 0 with error in convertToMysqlYear

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
mysql> create table t (y year);
Query OK, 0 rows affected (0.01 sec)

mysql> insert ignore into t values(2156);
Query OK, 1 row affected, 1 warning (0.00 sec)

mysql> insert ignore into t values(999999999999999999999999999);
Query OK, 1 row affected, 1 warning (0.00 sec)

mysql> insert ignore into t values(1900);
Query OK, 1 row affected, 1 warning (0.00 sec)

mysql> insert ignore into t values(1900.5);
Query OK, 1 row affected (0.00 sec)

mysql> select * from t;
+------+
| y    |
+------+
| 0000 |
| 0000 |
| 0000 |
| 1901 |
+------+
4 rows in set (0.00 sec)

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix YEAR compatibility, inserting invalid year value will be "0000"

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 16, 2019

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit 56d9d25 into pingcap:release-2.1 Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants