Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: annotate the previous statement to the error when transaction commit failed (#12087) #12747

Merged
merged 1 commit into from
Oct 16, 2019
Merged

session: annotate the previous statement to the error when transaction commit failed (#12087) #12747

merged 1 commit into from
Oct 16, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Oct 16, 2019

What problem does this PR solve?

Cherry pick #12087 to release 2.1.

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. type/2.1 cherry-pick labels Oct 16, 2019
@jackysp jackysp requested review from coocood and lysu October 16, 2019 03:20
@coocood
Copy link
Member

coocood commented Oct 16, 2019

LGTM

lysu
lysu approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 16, 2019
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit a55ead0 into pingcap:release-2.1 Oct 16, 2019
@jackysp jackysp deleted the prev_commit_err_2.1 branch February 27, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackysp @coocood @sre-bot @lysu @ngaut