Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: make requests fail quickly when the dial times out. (#12819) #12926

Merged
merged 2 commits into from
Oct 28, 2019
Merged

tikv: make requests fail quickly when the dial times out. (#12819) #12926

merged 2 commits into from
Oct 28, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Oct 25, 2019

cherry-pick #12819 to 3.0

# Conflicts:
#	store/tikv/client_batch.go

conflict caused by logutil.Bg() => logutil.Context(context.Backgrou())


This change is Reviewable

# Conflicts:
#	store/tikv/client_batch.go
@lysu lysu added component/tikv needs-cherry-pick-3.0 type/enhancement The issue or PR belongs to an enhancement. labels Oct 25, 2019
@lysu
Copy link
Contributor Author

lysu commented Oct 25, 2019

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2019
@lysu lysu requested a review from tiancaiamao October 28, 2019 06:39
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2019
@lysu lysu changed the title tikv: make requests fail-fast for dial timeouted (#12819) tikv: make requests fail quickly when the dial times out. (#12819) Oct 28, 2019
@ngaut ngaut merged commit 36d9730 into pingcap:release-3.0 Oct 28, 2019
@lysu
Copy link
Contributor Author

lysu commented Nov 8, 2019

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

cherry pick to release-3.1 in PR #13286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants