domain: refine error code for package domain #13033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
force-pushed
the
bb7133/fix_domain_errcode
branch
from
4fdf68a
to
c82b145
Compare
bb7133
force-pushed
the
bb7133/fix_domain_errcode
branch
2 times, most recently
from
b30f6bb
to
a9d548e
Compare
|
/run-unit-test |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@bb7133 merge failed. |
|
Close this PR temporarily because of PR quota |
bb7133
force-pushed
the
bb7133/fix_domain_errcode
branch
3 times, most recently
from
8e3c730
to
ec49fbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #13033 +/- ##
===========================================
Coverage 80.6663% 80.6663%
===========================================
Files 469 469
Lines 114500 114500
===========================================
Hits 92363 92363
Misses 15207 15207
Partials 6930 6930 |
|
/rebuild |
|
/run-all-tests |
zimulala
reviewed
Nov 7, 2019
bb7133
force-pushed
the
bb7133/fix_domain_errcode
branch
from
2840e2f
to
5310a44
Compare
|
/run-unit-test |
Addressed, thanks |
|
/run-unit-test |
|
/run-all-tests |
|
PTAL @zimulala |
bb7133
force-pushed
the
bb7133/fix_domain_errcode
branch
from
119754d
to
6432c47
Compare
|
/run-all-tests |
jackysp
approved these changes
Nov 8, 2019
|
I think it should wait for some PRs which are trying to fix CI. |
|
/merge |
|
/run-all-tests |
|
@bb7133 merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Not all the errors in
domainpackage have error code.What is changed and how it works?
Add them. Related to pingcap/parser#595.
Check List
Tests
Code changes
Side effects