expression: panic in test mode if builtin function's PbCode unspecified #13334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990 and
wshwsh12
and removed request for
a team
Signed-off-by: Lonng <heng@lonng.org>
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #13334 +/- ##
================================================
- Coverage 80.5814% 80.2358% -0.3457%
================================================
Files 469 469
Lines 114638 112866 -1772
================================================
- Hits 92377 90559 -1818
- Misses 15198 15297 +99
+ Partials 7063 7010 -53 |
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
breezewish
previously approved these changes
Nov 12, 2019
zimulala
reviewed
Nov 12, 2019
|
/merge |
sre-bot
added
the
status/can-merge
lonng
added
status/LGT2
|
/run-all-tests |
breezewish
previously approved these changes
Nov 12, 2019
Signed-off-by: Lonng <heng@lonng.org>
breezewish
approved these changes
Nov 12, 2019
zimulala
reviewed
Nov 12, 2019
| @@ -30,6 +31,14 @@ import ( | |||
| "github.com/pingcap/tipb/go-tipb" | |||
| ) | |||
|
|
|||
| func init() { | |||
| fpname := "github.com/pingcap/tidb/expression/PanicIfPbCodeUnspecified" | |||
There was a problem hiding this comment.
Why not put it to TestPanicIfPbCodeUnspecified?
There was a problem hiding this comment.
It's should affect all tests.
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
…ed (pingcap#13334) Signed-off-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
tipbto the latest version which makes detect missing PbCode easily.What is changed and how it works?
Update go.mod and add a fail point to build expression to Protobuf.
Check List
Tests
Release note