Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor the code of buildUpdate to solve some bugs (#13208) #13350

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Nov 11, 2019

cherry-pick #13208

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Nov 11, 2019
@winoros
Copy link
Member Author

winoros commented Nov 11, 2019

/run-all-tests tidb-test=pr/944

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

@winoros merge failed.

@winoros
Copy link
Member Author

winoros commented Nov 11, 2019

/run-all-tests tidb-test=pr/944

@eurekaka eurekaka merged commit 3663a39 into pingcap:release-3.0 Nov 11, 2019
@winoros winoros deleted the 3.0-pick branch November 17, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants