Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor the code of buildUpdate to solve some bugs (#13208) #13357

Merged
merged 5 commits into from
Dec 17, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Nov 11, 2019

Cherry-pick #13208
And cherry-pick a needed commit #10085

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Nov 11, 2019
@winoros
Copy link
Member Author

winoros commented Nov 11, 2019

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Nov 13, 2019

/run-unit-test

@bb7133 bb7133 added this to the v2.1.19 milestone Nov 22, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2019
@winoros
Copy link
Member Author

winoros commented Dec 17, 2019

/run-unit-test

@eurekaka
Copy link
Contributor

@winoros unit test fails, PTAL

@winoros
Copy link
Member Author

winoros commented Dec 17, 2019

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Dec 17, 2019

/run-unit-test

@winoros
Copy link
Member Author

winoros commented Dec 17, 2019

@eurekaka The executor's test would timeout randomly.

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka merged commit f472a98 into pingcap:release-2.1 Dec 17, 2019
@winoros winoros deleted the 2.1-pick branch November 17, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants