Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinNullEQIntSig #13565

Merged
merged 4 commits into from
Nov 20, 2019
Merged

expression: implement vectorized evaluation for builtinNullEQIntSig #13565

merged 4 commits into from
Nov 20, 2019

Conversation

AerysNan
Copy link
Contributor

Signed-off-by: AerysNan aerysnan@gmail.com

PCP #12103

What problem does this PR solve?

Implement vectorized evaluation for builtinNullEQSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinCompareFunc/builtinNullEQIntSig-VecBuiltinFunc-4                247856              4530 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCompareFunc/builtinNullEQIntSig-NonVecBuiltinFunc-4              33778             34065 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@AerysNan
vectorize builtinNullEQIntSig
0c36ad2 
Signed-off-by: AerysNan <aerysnan@gmail.com>
@AerysNan AerysNan requested a review from a team as a code owner November 19, 2019 05:27
@ghost ghost requested a review from wshwsh12 November 19, 2019 05:27
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from XuHuaiyu and removed request for a team November 19, 2019 05:27
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 19, 2019
@AerysNan
Copy link
Contributor Author

BTW, I find that there are two test files, i.e. builtin_compare_vec_generated_test and builtin_control_vec_generated_test.go. The former one seems to be built by go generate but NullEQInt isn't included. So I manually add the test case to the latter test file. Is it OK with that?

@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #13565 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #13565   +/-   ##
=========================================
  Coverage   80.006%   80.006%           
=========================================
  Files          472       472           
  Lines       116020    116020           
=========================================
  Hits         92823     92823           
  Misses       15921     15921           
  Partials      7276      7276

wshwsh12
wshwsh12 reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2019
@b41sh
Copy link
Member

b41sh commented Nov 19, 2019

BTW, I find that there are two test files, i.e. builtin_compare_vec_generated_test and builtin_control_vec_generated_test.go. The former one seems to be built by go generate but NullEQInt isn't included. So I manually add the test case to the latter test file. Is it OK with that?

It's ok. We did not implement builtinNullEQIntSig in generator.

@b41sh
Copy link
Member

b41sh commented Nov 19, 2019

LGTM

Reminiscent
Reminiscent approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

/run-all-tests

@sre-bot sre-bot merged commit 761ff1d into pingcap:master Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

@AerysNan complete task #12103 and get 50 score, currerent score 200.

@AerysNan AerysNan deleted the vectorize/builtinNullEQIntSig branch November 20, 2019 02:23
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@AerysNan @XiaTianliang
expression: implement vectorized evaluation for builtinNullEQIntSig (…
3252a72 
…pingcap#13565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@b41sh b41sh b41sh left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AerysNan @sre-bot @b41sh @wshwsh12 @Reminiscent @qw4990