expression: fix the corner case of CAST int as unsigned real/decimal #13637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
Deardrops
added
component/expression
needs-cherry-pick-2.1
priority/release-blocker
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #13637 +/- ##
================================================
- Coverage 80.3222% 80.0678% -0.2545%
================================================
Files 474 473 -1
Lines 117605 116465 -1140
================================================
- Hits 94463 93251 -1212
- Misses 15759 15854 +95
+ Partials 7383 7360 -23 |
Deardrops
removed
the
priority/release-blocker
This was referenced Nov 21, 2019
|
@qw4990 PTAL |
|
@djshow832, @SunRunAway, @qw4990, PTAL. |
lonng
reviewed
Nov 25, 2019
lonng
reviewed
Nov 25, 2019
lonng
reviewed
Nov 25, 2019
Deardrops
force-pushed
the
fix-unsigned-bug
branch
from
e9a7680
to
ed64f0c
Compare
|
/run-all-tests |
Deardrops
added
status/LGT2
|
/run-all-tests |
lonng
reviewed
Nov 26, 2019
| @@ -461,9 +461,10 @@ func (b *builtinCastIntAsRealSig) evalReal(row chunk.Row) (res float64, isNull b | |||
| if isNull || err != nil { | |||
| return res, isNull, err | |||
| } | |||
| if !mysql.HasUnsignedFlag(b.tp.Flag) && !mysql.HasUnsignedFlag(b.args[0].GetType().Flag) { | |||
| if unsignedArgs0 := mysql.HasUnsignedFlag(b.args[0].GetType().Flag); !mysql.HasUnsignedFlag(b.tp.Flag) && !unsignedArgs0 { | |||
There was a problem hiding this comment.
How about:
} else if b.inUnion && !unsignedArgs0 && val < 0 {
// Round up to 0 if the value is negative but the expression eval type is unsigned in `UNION` statement
// NOTE: the following expressions are equal (so choose the more efficient one):
// `b.inUnion && mysql.HasUnsignedFlag(b.tp.Flag) && !unsignedArgs0 && val < 0`
// `b.inUnion && !unsignedArgs0 && val < 0`
res = 0
} else {
lonng
changed the title
builtinCastIntAsRealSig and builtinCastIntAsDecimalSig that treat unsigned val as signed val
|
/run-all-tests |
lonng
approved these changes
Nov 26, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
Deardrops
added a commit
to Deardrops/tidb
that referenced
this pull request
Nov 26, 2019
Deardrops
added a commit
to Deardrops/tidb
that referenced
this pull request
Nov 26, 2019
This was referenced Nov 26, 2019
ngaut
pushed a commit
that referenced
this pull request
Nov 27, 2019
ngaut
pushed a commit
that referenced
this pull request
Nov 27, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the original version, it will check inUnion && val<0 no matter whether the val is unsigned(the val is always int64, but in sql, it may be unsigned), so in some case, it will dirrerent from mysql5.7
This PR continue unfinished work in #11745.
What is changed and how it works?
add check of whether unsigned
Check List
Tests
Code changes
Side effects
Related changes
Release note