Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinBenchmarkSig #13643

Merged
merged 7 commits into from
Dec 16, 2019
Merged

expression: implement vectorized evaluation for builtinBenchmarkSig #13643

merged 7 commits into from
Dec 16, 2019

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Nov 20, 2019

PCP #12103

What problem does this PR solve?

Implement vectorized evaluation for builtinBenchmarkSig at #12103

What is changed and how it works?

It gets faster about 60x.

Check List

Tests

  • Unit test
> GO111MODULE=on go test -check.f TestVectorizedBuiltinInfoFunc
PASS: builtin_info_vec_test.go:98: testEvaluatorSuite.TestVectorizedBuiltinInfoFunc	0.038s
OK: 1 passed
PASS
ok  	github.com/pingcap/tidb/expression	0.064s
  • Benchmark
> go test -v -benchmem -bench=BenchmarkVectorizedBuiltinInfoFunc -run=BenchmarkVectorizedBuiltinInfoFunc -args builtinBenchmarkSig
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinInfoFunc/builtinBenchmarkSig-VecBuiltinFunc-12         	  970549	      1209 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinInfoFunc/builtinBenchmarkSig-NonVecBuiltinFunc-12      	   15642	     74983 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	4.149s

@pingyu pingyu requested a review from a team as a code owner November 20, 2019 16:01
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from qw4990 and XuHuaiyu November 20, 2019 16:01
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 20, 2019
@ghost ghost removed their request for review November 20, 2019 16:01
XuHuaiyu
XuHuaiyu reviewed Nov 27, 2019
View reviewed changes
expression/builtin_info_vec.go Outdated Show resolved Hide resolved
expression/builtin_info.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 27, 2019 •
edited
Loading

Codecov Report

Merging #13643 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13643   +/-   ##
===========================================
  Coverage   80.1835%   80.1835%           
===========================================
  Files           483        483           
  Lines        121359     121359           
===========================================
  Hits          97310      97310           
  Misses        16301      16301           
  Partials       7748       7748

@qw4990 qw4990 requested a review from XuHuaiyu December 9, 2019 06:21
@qw4990
Copy link
Contributor

qw4990 commented Dec 9, 2019

Rest, LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

@pingyu, please update your pull request.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

@pingyu, please update your pull request.

qw4990
qw4990 reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 10, 2019
@qw4990 qw4990 requested a review from wshwsh12 December 12, 2019 08:48
XuHuaiyu
XuHuaiyu approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit ef56f3e into pingcap:master Dec 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 16, 2019

@pingyu complete task #12103 and get 50 score, currerent score 500.

Reminiscent pushed a commit to Reminiscent/tidb that referenced this pull request Dec 17, 2019
@pingyu @Reminiscent
expression: implement vectorized evaluation for builtinBenchmarkSig (…
ed43031 
…pingcap#13643)
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@pingyu @XiaTianliang
expression: implement vectorized evaluation for builtinBenchmarkSig (…
9982a97 
…pingcap#13643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pingyu @sre-bot @qw4990 @XuHuaiyu @Reminiscent