executor: refine the check of onlyFullGroupBy when groupByItem is parenthesesExpr or UnaryPlusExpr #13655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
alivxxx
reviewed
Nov 21, 2019
planner/core/logical_plan_builder.go
Outdated
| @@ -1910,14 +1910,18 @@ func (b *PlanBuilder) checkOnlyFullGroupByWithGroupClause(p LogicalPlan, sel *as | |||
| gbyColNames := make(map[*types.FieldName]struct{}, len(sel.Fields.Fields)) | |||
| gbyExprs := make([]ast.ExprNode, 0, len(sel.Fields.Fields)) | |||
| for _, byItem := range sel.GroupBy.Items { | |||
| if colExpr, ok := byItem.Expr.(*ast.ColumnNameExpr); ok { | |||
| expr := byItem.Expr | |||
| if pe, ok := expr.(*ast.ParenthesesExpr); ok { | |||
There was a problem hiding this comment.
Should the UnaryPlusExpr be handled? If so, just call the function directly?
Codecov Report
@@ Coverage Diff @@
## master #13655 +/- ##
===========================================
Coverage 79.9886% 79.9886%
===========================================
Files 473 473
Lines 116284 116284
===========================================
Hits 93014 93014
Misses 15964 15964
Partials 7306 7306 |
XuHuaiyu
changed the title
zimulala
approved these changes
Nov 21, 2019
zimulala
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 13168 |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 21, 2019
…enthesesExpr or UnaryPlusExpr (pingcap#13655)
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
…enthesesExpr or UnaryPlusExpr (pingcap#13655)
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @XuHuaiyu PTAL. |
|
/run-cherry-picker |
|
cherry pick to release-2.1 in PR #16145 |
XuHuaiyu
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 9, 2020
…enthesesExpr or UnaryPlusExpr (pingcap#13655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue #13652
What is changed and how it works?
Add the check for ParenthesesExpr and UnaryPlusExpr in checkOnlyFullGroupByWithGroupClause
Check List
Tests
Code changes
Side effects
N/A
Related changes
Release note
Make the check of SQL Mode only_full_group_by correct when the group by items is wrapped with parentheses.