Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix not null flag for using and natural join (#13735) #13739

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Nov 26, 2019

Cherry pick #13735
Conflicts: logical_plan_builder.go

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

Sorry @crazycs520, you don't have permission to trigger auto merge event on this branch.

@ngaut ngaut merged commit e8e0fe9 into pingcap:release-3.0 Nov 26, 2019
@alivxxx alivxxx deleted the not-null branch December 4, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants