-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: show operators' disk consumption in results of EXPLAIN ANALYZE
#13764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminiscent
changed the title
[WIP] executor: show operators' memory consumption in results of
[WIP] executor: show operators disk consumption in results of Nov 27, 2019
EXPLAIN ANALYZE
EXPLAIN ANALYZE
Reminiscent
changed the title
[WIP] executor: show operators disk consumption in results of
[WIP] executor: show operators' disk consumption in results of Nov 27, 2019
EXPLAIN ANALYZE
EXPLAIN ANALYZE
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #13764 +/- ##
===========================================
Coverage 80.3169% 80.3169%
===========================================
Files 474 474
Lines 118264 118264
===========================================
Hits 94986 94986
Misses 15847 15847
Partials 7431 7431 |
Reminiscent
changed the title
[WIP] executor: show operators' disk consumption in results of
executor: show operators' disk consumption in results of Nov 27, 2019
EXPLAIN ANALYZE
EXPLAIN ANALYZE
/run-all-tests |
/run-all-tests |
SunRunAway
reviewed
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qw4990
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qw4990
added
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Dec 2, 2019
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #12625
Add a new column named
disk
in the results ofEXPLAIN ANALYZE
to display memory consumption of operators.After this PR, you can see:
What is changed and how it works?
Check List
Tests