Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cleanup error code #13874

Merged
merged 3 commits into from
Dec 3, 2019
Merged

*: cleanup error code #13874

merged 3 commits into from
Dec 3, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Dec 3, 2019

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Some error code is useless

What is changed and how it works?

Cleanup them.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Dec 3, 2019
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #13874 into master will decrease coverage by 0.121%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #13874        +/-   ##
================================================
- Coverage   80.2496%   80.1285%   -0.1211%     
================================================
  Files           475        475                
  Lines        117998     117601       -397     
================================================
- Hits          94693      94232       -461     
- Misses        15852      15906        +54     
- Partials       7453       7463        +10

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit 826e1d7 into pingcap:master Dec 3, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@jackysp jackysp deleted the cleanup branch February 27, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants