Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add configuration entry make TiDB version string configurable (#13775) #13904

Merged
merged 4 commits into from
Dec 5, 2019
Merged

config: add configuration entry make TiDB version string configurable (#13775) #13904

merged 4 commits into from
Dec 5, 2019

Conversation

reafans
Copy link
Contributor

@reafans reafans commented Dec 4, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick #13775 to release-2.1

It can improve the hard-coding of serverVersion property.

What is changed and how it works?

add the serverVersion in config/config.go and config/config.toml.example

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Release note

@reafans reafans closed this Dec 5, 2019
@reafans reafans deleted the release-2.1 branch December 5, 2019 02:00
@reafans reafans restored the release-2.1 branch December 5, 2019 02:16
@reafans reafans reopened this Dec 5, 2019
@reafans
Copy link
Contributor Author

reafans commented Dec 5, 2019

/run-all-test

@reafans
Copy link
Contributor Author

reafans commented Dec 5, 2019

/run-all-tests

djshow832
djshow832 reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2019
Deardrops
Deardrops approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@Deardrops Deardrops added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2019
AilinKid
AilinKid reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/all tests passed status/can-merge Indicates a PR has been approved by a committer. labels Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

Sorry @AilinKid, you don't have permission to trigger auto merge event on this branch.

@bb7133 bb7133 merged commit 8d279ad into pingcap:release-2.1 Dec 5, 2019
@reafans reafans deleted the release-2.1 branch December 13, 2019 06:56
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@djshow832 djshow832 djshow832 left review comments

@Deardrops Deardrops Deardrops approved these changes

Assignees
No one assigned
Labels
component/config contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reafans @sre-bot @Deardrops @AilinKid @djshow832 @bb7133