session: if txn invalid do not active it and return an error #13935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #13935 +/- ##
===========================================
Coverage 80.3329% 80.3329%
===========================================
Files 480 480
Lines 121035 121035
===========================================
Hits 97231 97231
Misses 16086 16086
Partials 7718 7718 |
|
/run-all-tests |
|
before: after: |
cfzjywxk
reviewed
Dec 6, 2019
| @@ -82,7 +82,7 @@ func (e *BatchPointGetExec) initialize(ctx context.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| txn, err := e.ctx.Txn(true) | |||
| txn, err := e.ctx.Txn(false) | |||
There was a problem hiding this comment.
Do we need to check all these Txn(true) usages, seems many
There was a problem hiding this comment.
I've checked all of them. In another way, if Txn(true), it prefers to return an error when txn is invalid, but all the tests passed.
coocood
reviewed
Dec 6, 2019
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
|
LGTM |
|
PTAL @cfzjywxk @lysu @tiancaiamao |
|
LGTM |
1 similar comment
|
LGTM |
tiancaiamao
approved these changes
Dec 9, 2019
tiancaiamao
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Dec 9, 2019
…#13935) Conflicts: executor/batch_point_get.go executor/point_get.go
jackysp
added a commit
that referenced
this pull request
Dec 11, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Jan 16, 2020
jackysp
pushed a commit
that referenced
this pull request
Jan 16, 2020
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Jan 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If txn invalid, it is better to do not active it and return an error.
What is changed and how it works?
We should obey some rules,
if session.Txn(true), the txn should always be valid otherwise return an error for it.
if session.Txn(false), maybe we do not need to active the txn or it is close due to the lazy execute select statement, we should always check the txn is valid or not.
Check List
Tests
Code changes
Related changes