Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized for builtinCastStringAsRealSig #13952

Closed
wants to merge 1 commit into from

Conversation

eggeek
Copy link
Contributor

@eggeek eggeek commented Dec 6, 2019

What problem does this PR solve?

  1. Add vectorized expression: builtinCastStringAsRealSig
  2. Add the corresponding test case
  3. Add the corresponding generator: realStringGener

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsRealSig-VecBuiltinFunc-8             10000            102142 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsRealSig-NonVecBuiltinFunc-8           8454            132102 ns/op               0 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      2.785s

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • No

Related changes

  • No

Release note

  • No

@eggeek eggeek requested a review from a team as a code owner December 6, 2019 10:28
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 6, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team December 6, 2019 10:28
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #13952 into master will decrease coverage by 0.017%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #13952        +/-   ##
================================================
- Coverage   80.4459%   80.4288%   -0.0171%     
================================================
  Files           480        480                
  Lines        121627     121255       -372     
================================================
- Hits          97844      97524       -320     
+ Misses        16093      16035        -58     
- Partials       7690       7696         +6

@sre-bot
Copy link
Contributor

sre-bot commented Dec 7, 2019

@eggeek Please sign up before pick a challenge.
You can signing up by file a issue here https://github.com/tidb-perf-challenge/pcp/

@sre-bot sre-bot closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants