Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix bug for logical rule outer join elimination (#13947) #14014

Merged
merged 4 commits into from
Dec 17, 2019
Merged

planner: fix bug for logical rule outer join elimination (#13947) #14014

merged 4 commits into from
Dec 17, 2019

Conversation

lzmhhh123
Copy link
Contributor

cherry-pick: #13947
conflicts: cmd/explaintest/r/explain_easy.result

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.0 cherry-pick labels Dec 10, 2019
francis0407
francis0407 reviewed Dec 10, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 10, 2019
winoros
winoros approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 17, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 17, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 17, 2019

@lzmhhh123 merge failed.

@ngaut ngaut merged commit 3ff5455 into pingcap:release-3.0 Dec 17, 2019
@lzmhhh123 lzmhhh123 deleted the cherry-pick-3.0-13947 branch December 17, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis0407 francis0407 francis0407 left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lzmhhh123 @sre-bot @winoros @francis0407 @ngaut @zz-jason