ddl: fix ErrGCTooEarly when adding an index to the partition table #14029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhuang2016
reviewed
Dec 12, 2019
Why we use |
Codecov Report
@@ Coverage Diff @@
## master #14029 +/- ##
===========================================
Coverage ? 80.1892%
===========================================
Files ? 482
Lines ? 120768
Branches ? 0
===========================================
Hits ? 96843
Misses ? 16202
Partials ? 7723 |
|
@wjhuang2016 |
|
LGTM |
tiancaiamao
added
status/LGT3
tiancaiamao
approved these changes
Dec 19, 2019
zimulala
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #14132 |
ngaut
pushed a commit
that referenced
this pull request
Dec 19, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The partition table has several
PartitionDefinition. EveryPartitionDefinitionwe will read the corresponding columns records and backfill the index data when adding an index. We will deal withPartitionDefinitionone by one.Before a
PartitionDefinitionread the records, we will usereorg.Job.SnapshotVerto get range information. When we have twoPartitionDefinition, and the first partition we do a long time. Then fetching the ranges for the second partition may encounter anErrGCTooEarlyerror.What is changed and how it works?
Using the current version to get the range of a partition table.
Check List
Tests
Related changes
Release note
ErrGCTooEarlywhen adding an index to the partition table