Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set global variable tidb_txn_mode to pessimistic during bootstrap. #14154

Merged
merged 3 commits into from
Dec 20, 2019
Merged

set global variable tidb_txn_mode to pessimistic during bootstrap. #14154

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf351ad
set global variable tidb_txn_mode to pessimistic during bootstrap.
coocood Dec 20, 2019
c819274
Merge branch 'master' into bootstrap-pessimistic
coocood Dec 20, 2019
da1dc58
Merge branch 'master' into bootstrap-pessimistic
sre-bot Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion session/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
"github.com/pingcap/parser/auth"
"github.com/pingcap/parser/mysql"
"github.com/pingcap/parser/terror"
"github.com/pingcap/tidb/config"
"github.com/pingcap/tidb/ddl"
"github.com/pingcap/tidb/domain"
"github.com/pingcap/tidb/infoschema"
Expand Down Expand Up @@ -967,7 +968,11 @@ func doDMLWorks(s Session) {
for k, v := range variable.SysVars {
// Session only variable should not be inserted.
if v.Scope != variable.ScopeSession {
value := fmt.Sprintf(`("%s", "%s")`, strings.ToLower(k), v.Value)
vVal := v.Value
if v.Name == variable.TiDBTxnMode && config.GetGlobalConfig().Store == "tikv" {
vVal = "pessimistic"
}
value := fmt.Sprintf(`("%s", "%s")`, strings.ToLower(k), vVal)
values = append(values, value)
}
}
Expand Down