-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Improve the performance of WindowExec
by using sliding window
#14294
Conversation
marge from pingcap
…w or segment tree pingcap#12967 just improve slide window of countOriginal4Int
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has some benchmarks for window functions in executor/benchmark_test.go
, could you modify it and provide a benchmark result to show how performance we gain.
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
…w or segment tree pingcap#12967 add benchmark
…o feat-slidingWindow
…w or segment tree pingcap#12967 add comment
This comment has been minimized.
This comment has been minimized.
…w or segment tree pingcap#12967 fix EvalReal
This comment has been minimized.
This comment has been minimized.
…w or segment tree pingcap#12967 optimize windowFunc.(aggfuncs.SlidingWindowAggFunc)
benchstat result
|
WindowExec
by using sliding window
…ndow pingcap#14294 fix initializedSlidingWindow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ndow pingcap#14294 implement range clause of SlidingWindowExec fix window_test_case
…ndow pingcap#14294 WindowingUseHighPrecision
…ndow pingcap#14294 aggFuncSum bench
…ndow pingcap#14294 aggFuncSum bench
…ndow pingcap#14294 aggFuncSum bench
What problem does this PR solve?
Improve the performance of
WindowExec
by using sliding window or segment tree #12967What is changed and how it works?
1 add a interface named SlidingWindowAggFunc for evaluating the window aggregate functions using sliding window
2 modify the rowFrameWindowProcessor.appendResult2Chunk to use sliding window
Check List
Tests
Code changes
Benchmark
before
now
benchstat