Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, executor: correct the funcName for wrapWithIsTrue (#14515) #14516

Merged
merged 2 commits into from
Jan 19, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 17, 2020

cherry-pick #14515 to release-3.0


What problem does this PR solve?

Fix #14514

What is changed and how it works?

Correct the name of function IsTrue in wrapWithIsTrue.
In SimplifyOuterJoin, all the columns will be replaced by null, and the function will be reconstructed. The invalid function name before this commit will cause a panic.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 17, 2020

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 19, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 19, 2020

/run-all-tests

@zz-jason zz-jason merged commit 69dc332 into pingcap:release-3.0 Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants