Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: set default db for bindings correctly (#14077) #14548

Merged
merged 2 commits into from
Jan 20, 2020
Merged

bindinfo: set default db for bindings correctly (#14077) #14548

merged 2 commits into from
Jan 20, 2020

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jan 20, 2020

Cherry pick #14077

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 20, 2020
bb7133
bb7133 reviewed Jan 20, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jan 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 52dae01 into pingcap:release-3.0 Jan 20, 2020
@alivxxx alivxxx deleted the implict-db branch February 17, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v3.0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @sre-bot @bb7133 @zz-jason