Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix wrong result of BatchPointGet when plan cache is enabled #14855

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Fix #14852

What is changed and how it works?

Previously, for the second execute of BatchPointGet, we would only update the first parameter handle because of early return. Remove this incorrect "return".

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

N/A

Release note

  • Write release note for bug-fix or new feature.
    Fix wrong result of BatchPointGet when plan cache is enabled.

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Feb 19, 2020
@eurekaka eurekaka requested a review from a team as a code owner February 19, 2020 12:57
@ghost ghost requested review from lzmhhh123 and winoros and removed request for a team February 19, 2020 12:57
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 19, 2020
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 19, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6151db3 into pingcap:master Feb 19, 2020
@eurekaka eurekaka deleted the batch_point branch February 19, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorect batch point get plan when prepare plan cache enabled
4 participants