Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: change enable-slow-log to boolean #14864

Merged
merged 3 commits into from
Feb 20, 2020
Merged

config: change enable-slow-log to boolean #14864

merged 3 commits into from
Feb 20, 2020

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Feb 20, 2020 •
edited
Loading

What problem does this PR solve?

boolean is more intuitive for users than 1/0
A fix PR for #14016

What is changed and how it works?

change enable-slow-log to bool

Check List

Tests

  • None

@SunRunAway SunRunAway added sig/execution SIG execution component/config type/enhancement The issue or PR belongs to an enhancement. and removed sig/execution SIG execution labels Feb 20, 2020
zimulala
zimulala reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway mentioned this pull request Feb 20, 2020
Merged
12 tasks
qw4990
qw4990 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Feb 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6b09729 into pingcap:master Feb 20, 2020
@SunRunAway SunRunAway deleted the slowlog branch February 20, 2020 07:40
@kennytm kennytm mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@qw4990 qw4990 qw4990 approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SunRunAway @sre-bot @zimulala @qw4990