Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: support check the "CommanName" of tls-cert for status-port(http/grpc) (#15137) #15164

Merged
merged 1 commit into from
Mar 6, 2020
Merged

server: support check the "CommanName" of tls-cert for status-port(http/grpc) (#15137) #15164

merged 1 commit into from
Mar 6, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 5, 2020

cherry-pick #15137 to release-3.0

What problem does this PR solve?

add CN check for TiDB's http/grpc API

What is changed and how it works?

  • add configuration
  • config check hook in http/grpc server
  • add test

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
remove https://github.com/pingcap/tidb/compare/master...lysu:check_CN_between_tidbs?expand=1#diff-209d74aa1a4826e6cf6e0b29455087c7R221
and install self-signed CA to operation-system

Code changes

  • n/a

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release 3.0

Release note

  • Write release note for bug-fix or new feature.

This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 5, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Mar 5, 2020
Merged
@sre-bot sre-bot added security Everything related with security status/all-tests-passed labels Mar 5, 2020
@lysu lysu force-pushed the release-3.0-92f6f4ef8400 branch from a0f44dc to fa8f260 Compare March 5, 2020 16:51
jackysp
jackysp approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 6, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit 11ec003 into pingcap:release-3.0 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@gregwebs gregwebs gregwebs approved these changes

@imtbkcat imtbkcat Awaiting requested review from imtbkcat

Assignees
No one assigned
Labels
security Everything related with security status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @jackysp @gregwebs @lysu