executor: solve bug of copy joined tuples after inline projection #15411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
reviewed
Mar 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #15411 +/- ##
================================================
+ Coverage 80.3898% 80.5645% +0.1747%
================================================
Files 502 502
Lines 134058 134872 +814
================================================
+ Hits 107769 108659 +890
+ Misses 17819 17771 -48
+ Partials 8470 8442 -28 |
|
/run-unit-test |
SunRunAway
reviewed
Mar 17, 2020
SunRunAway
reviewed
Mar 17, 2020
ghost
requested review from
eurekaka and
winoros
and removed request for
a team
SunRunAway
reviewed
Mar 18, 2020
SunRunAway
reviewed
Mar 18, 2020
|
/rebuild |
XuHuaiyu
added
status/can-merge
|
/run-all-tests |
|
@fzhedu merge failed. |
fzhedu
changed the title
|
/rebuild |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
close #15316
close #15313
close #15312
close #15302
close #15299
Problem Summary: after taking inline projection, the outer part of a jointed rows may be pruned, so it cannot directly use
chunk.CopySelectedJoinRowsWithSameOuterRows().What is changed and how it works?
What's Changed: change the
chunk.CopySelectedJoinRowsWithSameOuterRows()to solve the cases without outers.How it Works: correctly copy inner part, and ignore the outer part.
Check List
Tests