Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix wrong behavior in values function for Bit(1). (#15350) #15485

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 19, 2020

cherry-pick #15350 to release-2.1


What problem does this PR solve?

Fixes #15310

What is changed and how it works?

Check the data length in built-in function ValuesInt().

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch 2.1 and 3.0

Release note

Fix wrong behavior in values function for type bit(n).

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 19, 2020

/run-all-tests

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wshwsh12 Please fix the CI problem.

@wshwsh12 wshwsh12 requested a review from qw4990 March 24, 2020 08:53
@github-actions github-actions bot added the sig/execution SIG execution label Mar 24, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2020
@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 25, 2020

Your auto merge job has been accepted, waiting for 15487

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3a5c5d0 into pingcap:release-2.1 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants