planner: add warning when join hint has no arguments #15583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis0407
added
type/bugfix
ghost
requested review from
eurekaka and
lzmhhh123
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15583 +/- ##
===========================================
Coverage ? 80.4083%
===========================================
Files ? 504
Lines ? 134649
Branches ? 0
===========================================
Hits ? 108269
Misses ? 17895
Partials ? 8485 |
lzmhhh123
reviewed
Mar 24, 2020
| @@ -2195,23 +2205,45 @@ func (b *PlanBuilder) pushTableHints(hints []*ast.TableOptimizerHint, nodeType n | |||
| for _, hint := range hints { | |||
| switch hint.HintName.L { | |||
There was a problem hiding this comment.
What about check hint.Tables before the switch. Then we can reduce much redundant code.
There was a problem hiding this comment.
Yes, I have merged these codes. PTAL
…nt_warning # Conflicts: # planner/core/logical_plan_builder.go # planner/core/testdata/integration_suite_in.json
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 15678, 15773, 15552 |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 30, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15874 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 30, 2020
|
cherry pick to release-4.0 in PR #15875 |
ngaut
pushed a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
This PRs adds warning when join hint has no arguments.
warning message:
What is changed and how it works?
How it Works:
check whether the hint.Tables is empty.
Related changes
Check List
Tests
Release note
adds warning message when join hint has no arguments.