server, session: refine mysql handshake error log #15731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15731 +/- ##
================================================
- Coverage 80.5057% 80.3831% -0.1226%
================================================
Files 504 502 -2
Lines 134742 134369 -373
================================================
- Hits 108475 108010 -465
- Misses 17803 17856 +53
- Partials 8464 8503 +39 |
|
LGTM |
jackysp
approved these changes
Mar 28, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #15798 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15799 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 28, 2020
|
cherry pick to release-4.0 in PR #15800 |
sre-bot
added a commit
that referenced
this pull request
Mar 29, 2020
zz-jason
pushed a commit
that referenced
this pull request
Mar 30, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
now, we log out too many EOF log due to port health check
What is changed and how it works?
make handshake EOF error be logged as
INFOlevel(or debug?) and suspend stack info for themWhat's Changed:
How it Works:
log inside handshake method
Related changes
Check List
Tests
Side effects
Release note
refine mysql mysql handshake error log
This change is