Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: check for null values when comparing different groups during streamAgg (#15742) #15777

Merged
merged 3 commits into from
Mar 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 27, 2020

cherry-pick #15742 to release-4.0


What problem does this PR solve?

Close #15690
Close #15691
Close #15695
Close #15696
In the master version, we forget to check the null value when we compare the different groups during StreamAgg.

What is changed and how it works?

Add checks for null values when comparing different groups during StreamAgg.

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot requested a review from a team as a code owner March 27, 2020 08:43
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 27, 2020

/run-all-tests

@ghost ghost requested a review from qw4990 March 27, 2020 08:43
@sre-bot sre-bot added sig/execution SIG execution priority/release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Mar 27, 2020
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent
Copy link
Contributor

/run-unit-test

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 27, 2020

Sorry @Reminiscent, you don't have permission to trigger auto merge event on this branch.

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Mar 27, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 27, 2020

Your auto merge job has been accepted, waiting for 15768

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 27, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 27, 2020

@sre-bot merge failed.

@XuHuaiyu
Copy link
Contributor

/run-unit-test

@XuHuaiyu XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 27, 2020
@ngaut ngaut merged commit c07728a into pingcap:release-4.0 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants