Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: change 2PC goroutines rate limit to 16 #15816

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Mar 30, 2020

What problem does this PR solve?

Issue Number: #15794

Problem Summary:

During the test, I find the rate limit 32 makes tikv server is busy.

What is changed and how it works?

I'm not yet come up with the idea for issue 15794,
so reduce the value to 16 is a much safe way.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • Performance regression

@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-4.0 labels Mar 30, 2020
@tiancaiamao
Copy link
Contributor Author

PTAL @jackysp @youjiali1995

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #15816 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15816   +/-   ##
===========================================
  Coverage   80.6213%   80.6213%           
===========================================
  Files           504        504           
  Lines        136191     136191           
===========================================
  Hits         109799     109799           
  Misses        17813      17813           
  Partials       8579       8579           

@tiancaiamao tiancaiamao added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 30, 2020
Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 30, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

@tiancaiamao merge failed.

@tiancaiamao
Copy link
Contributor Author

/rebuild

[error="listen tcp 0.0.0.0:10081: bind: address already in use"]

@tiancaiamao tiancaiamao merged commit 03b510e into pingcap:master Mar 30, 2020
@tiancaiamao tiancaiamao deleted the 2pc-rate-limit branch March 30, 2020 10:30
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 30, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

cherry pick to release-4.0 in PR #15856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants