planner: fix panic of merge join for tables with redundant indexes #15840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #15840 +/- ##
================================================
- Coverage 80.4676% 80.4181% -0.0496%
================================================
Files 505 505
Lines 135043 135028 -15
================================================
- Hits 108666 108587 -79
- Misses 17889 17936 +47
- Partials 8488 8505 +17 |
|
/rebuild |
|
/rebuild |
2 similar comments
|
/rebuild |
|
/rebuild |
|
do we need to cherry pick to other releases? |
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 15853, 15757 |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 31, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #15918 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 31, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15919 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 31, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15920 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 31, 2020
|
cherry pick to release-4.0 in PR #15921 |
sre-bot
added a commit
that referenced
this pull request
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15813
Problem Summary:
MergeJoin for tables with redundant index would panic.
What is changed and how it works?
Proposal: xxx
What's Changed:
Use length of de-duplicated conditions instead of original length for declaring slice in
moveEqualToOtherConditions.How it Works:
Avoid the capacity of slice to be out of bound.
Related changes
Check List
Tests
Side effects
N/A
Release note