ddl: fix drop index failed when index contain auto_increment column and the auto_increment column is primary key #15861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the auto_increment column is primary key Signed-off-by: crazycs520 <crazycs520@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #15861 +/- ##
===========================================
Coverage 80.5901% 80.5901%
===========================================
Files 505 505
Lines 135529 135529
===========================================
Hits 109223 109223
Misses 17821 17821
Partials 8485 8485 |
|
/run-all-tests |
|
LGTM |
zimulala
reviewed
Mar 31, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
zimulala
added
status/LGT2
zimulala
approved these changes
Apr 1, 2020
crazycs520
added
needs-cherry-pick-2.1
status/can-merge
|
Your auto merge job has been accepted, waiting for 15907, 15845, 15758, 15956, 15776, 15889, 15926, 15889 |
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16007 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 2, 2020
…nd the auto_increment column is primary key (pingcap#15861)
|
cherry pick to release-3.0 in PR #16008 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 2, 2020
…nd the auto_increment column is primary key (pingcap#15861)
|
cherry pick to release-3.1 in PR #16009 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 2, 2020
…nd the auto_increment column is primary key (pingcap#15861)
|
cherry pick to release-4.0 in PR #16010 |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Apr 9, 2020
…nd the auto_increment column is primary key (pingcap#15861) Signed-off-by: crazycs520 <crazycs520@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Before this PR:
What is changed and how it works?
Fix DDL drop index with
auto_increamentcheck function bug.Related changes
Check List
Tests
Side effects
Release note
Fix issue of drop index failed when index contain auto_increment column and the auto_increment column is the primary key.