Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix charset and collation for current_role #16019

Merged
merged 4 commits into from
Apr 4, 2020

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Apr 2, 2020

What problem does this PR solve?

#15250 didn't set charset and collation for current_role correctly, which cause current_role print binary collation result.

What is changed and how it works?

fix charset and collation for current_role

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

@imtbkcat imtbkcat requested review from qw4990 and winoros April 2, 2020 11:52
@imtbkcat imtbkcat requested a review from a team as a code owner April 2, 2020 11:52
@ghost ghost removed their request for review April 2, 2020 11:52
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

Your auto merge job has been accepted, waiting for 16005, 16022

@zz-jason zz-jason removed the request for review from winoros April 4, 2020 07:26
@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

@imtbkcat merge failed.

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #16019 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16019   +/-   ##
===========================================
  Coverage   80.5197%   80.5197%           
===========================================
  Files           505        505           
  Lines        135419     135419           
===========================================
  Hits         109039     109039           
  Misses        17904      17904           
  Partials       8476       8476           

@zz-jason
Copy link
Member

zz-jason commented Apr 4, 2020

/run-common-test
/run-sqllogic-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-3.0 in PR #16083

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-3.1 in PR #16084

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2020

cherry pick to release-4.0 in PR #16085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants