-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: fix partition selection on hash partitioned table #16070
planner/core: fix partition selection on hash partitioned table #16070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@tiancaiamao merge failed. |
/run-all-tests tidb-test=pr/fix-16070 |
/run-all-tests tidb-test=pr/1030 |
/run-all-tests tidb-test=pr/1030 |
/rebuild tidb-test=pr/1030 |
/run-integration-common-test tidb-test=pr/1030 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.1 in PR #16076 |
What problem does this PR solve?
See the test case.
What is changed and how it works?
Remove redundancy code and get back the missing code
https://github.com/pingcap/tidb/compare/release-3.0...tiancaiamao:partition-selection-on-hash?expand=1#diff-0411f48b4045359c9f116ef6a779c3efR736-R740
This bug exists on branch 3.0, the master branch is fine.
Tests