-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: correct column name with unary plus sign (#8702) #16149
Merged
SunRunAway
merged 3 commits into
pingcap:release-2.1
from
sre-bot:release-2.1-29c17a1eb961
Apr 8, 2020
Merged
planner/core: correct column name with unary plus sign (#8702) #16149
SunRunAway
merged 3 commits into
pingcap:release-2.1
from
sre-bot:release-2.1-29c17a1eb961
Apr 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/planner
SIG: Planner
contribution
This PR is from a community contributor.
type/2.1-cherry-pick
labels
Apr 8, 2020
/run-all-tests |
/run-all-tests |
lzmhhh123
reviewed
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winoros
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
XuHuaiyu
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Apr 8, 2020
SunRunAway
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Apr 8, 2020
Your auto merge job has been accepted, waiting for 16152, 16178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution
This PR is from a community contributor.
sig/execution
SIG execution
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/2.1-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8702 to release-2.1
What problem does this PR solve?
Column names returned by tidb are inconsistent with which returned by mysql when select field contains one or more positive signs.
The left one showes the result returned by master and the right one is the result returned by mysql.
What is changed and how it works?
Extract inner value from
UnaryOperationExpr
(just like the way we handle parentheses).Check List
Tests
This change is