Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: correct column name with unary plus sign (#8702) #16149

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 8, 2020

cherry-pick #8702 to release-2.1


What problem does this PR solve?

Column names returned by tidb are inconsistent with which returned by mysql when select field contains one or more positive signs.

2018-12-16_175602

The left one showes the result returned by master and the right one is the result returned by mysql.

What is changed and how it works?

Extract inner value from UnaryOperationExpr (just like the way we handle parentheses).

Check List

Tests

  • Unit test
  • Integration test

This change is Reviewable

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot sre-bot added sig/planner SIG: Planner contribution This PR is from a community contributor. type/2.1-cherry-pick labels Apr 8, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Apr 8, 2020
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 8, 2020

/run-all-tests

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 8, 2020

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2020
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2020
@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

Your auto merge job has been accepted, waiting for 16152, 16178

@SunRunAway SunRunAway merged commit a238da8 into pingcap:release-2.1 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/2.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants