-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: add syntax for setting the cache step of auto id explicitly. (#15409) #16287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
sig/sql-infra
SIG: SQL Infra
sig/execution
SIG execution
status/all-tests-passed
type/3.0-cherry-pick
labels
Apr 10, 2020
zimulala
reviewed
Apr 14, 2020
AilinKid
force-pushed
the
release-3.0-1c73deca59e4
branch
2 times, most recently
from
April 28, 2020 09:13
c1f2860
to
e9a6295
Compare
Signed-off-by: sre-bot <sre-bot@pingcap.com>
AilinKid
force-pushed
the
release-3.0-1c73deca59e4
branch
from
April 28, 2020 10:10
7069ae0
to
d3fe353
Compare
djshow832
reviewed
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
bb7133
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/LGT1
Indicates that a PR has LGTM 1.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15409 to release-3.0
conflict files
What problem does this PR solve?
That autoid allocator's cache step is quite big now, it will consume a lot of autoid when tidb restarts or crashes. For those scenes which treasure autoid heavily, it's not acceptable.
Parser link: #765
Problem Summary:
What is changed and how it works?
Add
auto_increment_cache
in create table / alter table statement and it will determine the allocator's cache step.But there is an exception when a statement like an insert batch(
insert into values()()...
) which requires allocating consecutive N autoid in one statement, we will make sure that the custom cache step is adequate for it withif step < N, then step = min(2N, maxstep)
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Release note:
ddl: add syntax for setting the cache step of auto id explicitly.