tikv: fix panic when recycle non-superbatch idle conn (#16299) #16303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16299 to release-4.0
What problem does this PR solve?
Problem Summary:
tidb-tikv will use superbatch conn as default, but "cluster table" will establish non-superbatch connection between tidb-tidb.
tidb/store/tikv/client.go
Line 322 in af0a49c
and superbatch due use streaming, it has recycle idle conn logic to avoid goroutine leak.
but "recycle idle conn logic" doesn't work well when conns map mix superbatch and non-superbatch conn, and will meet segv fault.
What is changed and how it works?
What's Changed:
only recycle superbatch conns
How it Works:
only recycle superbatch conns
Related changes
Check List
Tests
Side effects
Release note
This change is