Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix the modify column operation on the bit column (#12008) #16312

Merged
merged 2 commits into from
Apr 13, 2020
Merged

ddl: fix the modify column operation on the bit column (#12008) #16312

merged 2 commits into from
Apr 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 13, 2020

cherry-pick #12008 to release-2.1

What problem does this PR solve?

Before this PR：

create table t (i int, b bit);
alter table t modify b bit;
ERROR 1105 (HY000): unsupported modify column unsigned false not match origin true

Fix #11800

What is changed and how it works?

Add the UnsignedFlag to bit like add column when doing modify column.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the modify column operation on the bit column.

@zimulala @sre-bot
cherry pick pingcap#12008 to release-2.1
9b0de06 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 13, 2020
Merged
@github-actions github-actions bot added the sig/execution SIG execution label Apr 13, 2020
@zimulala
Copy link
Contributor

PTAL @tangenta @crazycs520

crazycs520
crazycs520 reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tangenta
tangenta approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Apr 13, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

Sorry @tangenta, you don't have permission to trigger auto merge event on this branch.

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala merged commit dc54c5d into pingcap:release-2.1 Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zimulala @tangenta @crazycs520