expression: Add the check for expression evaluation in some executors (#16339) #16383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/execution
|
/run-sqllogic-test-1 |
|
@qw4990 PTAL |
qw4990
added
status/LGT2
zz-jason
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
Reminiscent
changed the title
|
Wait for #16156 to fix the fail of the unit test. |
|
/merge |
|
Sorry @Reminiscent, you don't have permission to trigger auto merge event on this branch. |
|
/run-all-tests |
|
/build |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-integration-common-test |
2 similar comments
|
/run-integration-common-test |
|
/run-integration-common-test |
|
/run-all-tests |
ngaut
added
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
@zz-jason PTLA. Please help merge this PR. Thanks! |
|
/rebuild |
|
/rebuild |
|
/run-all-tests |
|
The failed test can be fixed by #16997 |
|
/run-integration-copr-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16339 to release-4.0
What problem does this PR solve?
Issue Number: close #16337
Problem Summary:
Lack of the check when we use expression evaluation in some executors.
What is changed and how it works?
Add the check to the
EvalExprto choose whether it uses theVecExprorExpr.Related changes
Rename
VecEvaltoEvalExpr.Add the check to the
EvalExprto choose whether it uses theVecExprorExpr.Check List
Tests
Release note