tikv: fix infinite retry when kv region continuing to return StaleCommand error (#16481) #16530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/tikv
status/PTAL
type/4.0-cherry-pick
type/bugfix
|
@coocood, @tiancaiamao, @jackysp, @crazycs520, PTAL. |
|
@coocood, @tiancaiamao, @jackysp, @crazycs520, PTAL. |
|
LGTM |
tiancaiamao
approved these changes
Apr 21, 2020
|
/merge |
|
Sorry @lysu, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16481 to release-4.0
What problem does this PR solve?
Issue Number: close #16524
Problem Summary:
tikv region will report staleCommand when it can not catch up the log and will let tidb do retry.
but stale error didn't use backoff util, so it will infinite loop when some kv region keep return stale.
it can be reproduced by
TestOnRegionErrorthis will make SQLs block forever if it hit those regions.
What is changed and how it works?
What's Changed:
do a little backoff before retry stale command,
How it Works:
do backoff, let retry loop has chances be broken by maxSleepTime or kill command
Related changes
Check List
Tests
Side effects
Release note
fix infinite retry when kv continuing to return staleCommand error
This change is