Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix wrong flen for case when function (#16352) #16562

Merged
merged 3 commits into from
Jun 28, 2020
Merged

expression: fix wrong flen for case when function (#16352) #16562

merged 3 commits into from
Jun 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 17, 2020 •
edited by lzmhhh123
Loading

cherry-pick #16352 to release-3.0

What problem does this PR solve?

Issue Number: close #16351

Problem Summary: the flen for case when function is wrong, that case setvar wrong results in some situations.

What is changed and how it works?

What's Changed: when meet unspecified flen, set it.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix wrong return length for case when function

@lzmhhh123 @sre-bot
cherry pick pingcap#16352 to release-3.0
0f653e2 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 17, 2020
Merged
@sre-bot sre-bot added this to the v3.0.13 milestone Apr 17, 2020
zz-jason
zz-jason reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzmhhh123 please resolve conflict and fix CI.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 9, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@lzmhhh123
Copy link
Contributor

/rebuild

@bb7133 bb7133 modified the milestones: v3.0.14, v3.0.15 May 19, 2020
@bb7133 bb7133 modified the milestones: v3.0.15, 3.0.16, v3.0.16 Jun 6, 2020
qw4990
qw4990 reviewed Jun 28, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@qw4990,Thanks for you review.

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2020
winoros
winoros reviewed Jun 28, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

@winoros, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

@ti-srebot
Copy link
Contributor

@winoros, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 33ffa35 into pingcap:release-3.0 Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 left review comments

@winoros winoros winoros approved these changes

Assignees

@lzmhhh123 lzmhhh123

Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.16
Development

Successfully merging this pull request may close these issues.
7 participants
@sre-bot @lzmhhh123 @ti-srebot @zz-jason @qw4990 @winoros @bb7133