Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix auto random base comment in show.go (#16859) #16864

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 27, 2020

cherry-pick #16859 to release-4.0


What problem does this PR solve?

Problem Summary: fix auto random base comment in show.go

What is changed and how it works?

How it Works: refine the show result iin show.go

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

executor: fix auto random base comment in show.go

Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested a review from a team as a code owner April 27, 2020 09:06
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 27, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

/run-unit-test

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 27, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 27, 2020

@sre-bot merge failed.

@AilinKid
Copy link
Contributor

/run-all-tests

@zimulala zimulala merged commit 3b81a7f into pingcap:release-4.0 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants