gc_worker: fix deadlock in physicalScanAndResolveLocks (#16393) #16915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/GC
type/4.0-cherry-pick
type/bugfix
youjiali1995
approved these changes
Apr 28, 2020
youjiali1995
added
the
status/can-merge
|
Sorry @youjiali1995, you don't have permission to trigger auto merge event on this branch. |
|
@bb7133 Please merge it. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-integration-copr-test |
1 similar comment
|
/run-integration-copr-test |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
|
/rebuild |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16393 to release-4.0
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #16304
Problem Summary:
It's possible to block on channel sending in physicalScanAndResolveLocks when error occours.
What is changed and how it works?
What's Changed:
Check
ctx.Done()when sending to a channel.How it Works:
Related changes
Check List
Tests
Side effects
Release note