gc_worker: compare locks by key and timestamp (#16536) #16948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/GC
type/4.0-cherry-pick
type/bugfix
youjiali1995
approved these changes
Apr 30, 2020
|
@bb7133 Please merge it. |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-integration-copr-test |
2 similar comments
|
/run-integration-copr-test |
|
/run-integration-copr-test |
|
/run-integration-copr-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16536 to release-4.0
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #16490
Problem Summary:
mergeReceivercompares locks by key so that we only resolve the first lock. It's possible a key has locks with different timestamps:What is changed and how it works?
What's Changed:
Compare locks by key and timestamp.
Related changes
Check List
Tests
Release note
Fix the issue that Green GC misses locks when a key has locks with different timestamps.