Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, executor: return err when INSERT/UPDATE/ANALYZE/DELETE a sequence (#16936) #16957

Merged
merged 4 commits into from
May 6, 2020
Merged

planner, executor: return err when INSERT/UPDATE/ANALYZE/DELETE a sequence (#16936) #16957

merged 4 commits into from
May 6, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 30, 2020 •
edited by AilinKid
Loading

cherry-pick #16936 to release-4.0

What problem does this PR solve?

Problem Summary: return err when INSERT/UPDATE/ANALYZE/DELETE a sequence

What is changed and how it works?

What's Changed:
judge table whether is a sequence when INSERT/UPDATE/ANALYSE/DELETE and return error.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • planner, executor: return err when INSERT/UPDATE/ANALYZE/DELETE a sequence

@sre-bot sre-bot requested review from a team as code owners April 30, 2020 08:56
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 30, 2020
Merged
@ghost ghost requested review from XuHuaiyu April 30, 2020 08:57
@sre-bot sre-bot added sig/execution SIG execution sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 30, 2020
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone Apr 30, 2020
djshow832
djshow832 reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

AilinKid commented May 6, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

AilinKid commented May 6, 2020

/run-check_release_note

@AilinKid
Copy link
Contributor

AilinKid commented May 6, 2020

/run-integration-copr-test

@AilinKid
Copy link
Contributor

AilinKid commented May 6, 2020

/run_check_release_note

@AilinKid
Copy link
Contributor

AilinKid commented May 6, 2020

/build

zimulala
zimulala approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label May 6, 2020
XuHuaiyu
XuHuaiyu approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 0cbecf4 into pingcap:release-4.0 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zimulala zimulala zimulala approved these changes

Assignees

@AilinKid AilinKid

Labels
sig/execution SIG execution sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @AilinKid @zimulala @XuHuaiyu @djshow832